Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query.DrawingArea - titleblock empty type bug fix #1404

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

michal-pekacki
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #1403

Added null check for empty symbol family types.

Test files

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:bug Error or unexpected behaviour label Sep 4, 2023
@michal-pekacki michal-pekacki self-assigned this Sep 4, 2023
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 4, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 4, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check installer

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 4, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve, the change makes sense. However, @michal-pekacki could you please update the PR title? The change does not look like a null check to me 🙈

@michal-pekacki michal-pekacki changed the title Query.DrawingArea null check added Query.DrawingArea - titleblock empty type bug fix Sep 6, 2023
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2023

@michal-pekacki to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

There are 8 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 98d7107 into develop Sep 6, 2023
11 checks passed
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1403-DrawingAreaNullCheck branch September 6, 2023 08:49
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add null check do DrawingArea
2 participants