Null check for familyLibrary in CategoryNames query method #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelbaran
added
size:S
ZiolkowskiJakub
approved these changes
Oct 11, 2019
|
Hi @FraserGreenroyd, Anything to add on this one? Shall I merge it? Thanks in advance. |
|
Hi no problems from me, I had a query but it was resolved, happy for you to merge 😄 |
ZiolkowskiJakub
deleted the
Revit_Toolkit-Issue387-CategoryNamesCrashOnNull
branch
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #387
Null catch to prevent the code from crashing - instead an informative error is returned.
Test files
Test file located here.
Changelog
Informative error given when requested family type does not exist in the Revit document.
Additional comments