Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NuGet references to Revit dlls #414

Merged
merged 5 commits into from
Oct 18, 2019
Merged

Remove NuGet references to Revit dlls #414

merged 5 commits into from
Oct 18, 2019

Conversation

ZiolkowskiJakub
Copy link
Member

NOTE: Depends on

N/A

Issues addressed by this PR

Closes #413
Closes #350

  • NuGet Packages with Revit libraries removed
  • Revit libraries added to libs folder and referenced in projects
  • Support for Revit 2020 added

Test files

Run Revit_Toolkit on any script

Changelog

  • *.csproj files changed to include new way of referencing Revit dll
  • packages.config removed
  • Revit_Toolkit.sln updated to include Debug2020 and Release2020 Solution Configurations

Additional comments

N/A

@ZiolkowskiJakub ZiolkowskiJakub added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Oct 17, 2019
@ZiolkowskiJakub ZiolkowskiJakub added this to the BHoM 3.0 β MVP milestone Oct 17, 2019
@ZiolkowskiJakub ZiolkowskiJakub self-assigned this Oct 17, 2019
michaldengusiak
michaldengusiak approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@michaldengusiak michaldengusiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I can export gbXML from Revit 2020.1 using Dynamo 1.3 Sandbox
image

@ZiolkowskiJakub ZiolkowskiJakub merged commit ef05901 into master Oct 18, 2019
@ZiolkowskiJakub ZiolkowskiJakub deleted the NuGetPacakages branch October 18, 2019 08:25
@al-fisher al-fisher mentioned this pull request Oct 19, 2019
Closed
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldengusiak michaldengusiak michaldengusiak approved these changes

@FraserGreenroyd FraserGreenroyd Awaiting requested review from FraserGreenroyd FraserGreenroyd is a code owner

@pawelbaran pawelbaran Awaiting requested review from pawelbaran pawelbaran is a code owner

Assignees

@ZiolkowskiJakub ZiolkowskiJakub

Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging this pull request may close these issues.

Support For Revit 2020 Remove NuGet references to Revit dlls
2 participants
@ZiolkowskiJakub @michaldengusiak