Updating default configurations for debug and release #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-fisher
added
severity:critical
FraserGreenroyd
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
I have managed to build through all configurations from default (Debug and Release) up to the 2018-2020 configurations.
I have managed to successfully pull a model from Revit into Rhino through the Revit Adapter.
I am approving this PR on the basis that I have managed to achieve the above. The model I pulled through was an Environmental model though, so I thoroughly recommend awaiting a review from @IsakNaslundBh prior to merging 😄
IsakNaslundBh
approved these changes
Oct 21, 2019
|
Fantastic - thanks both @FraserGreenroyd @IsakNaslundBh |
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #416
Following update of NuGets - have aligned the default
debugandreleasetodebug2018andrelease2018configurations to ensure any default set ups can also build.