Aligning with changes in BHoMAdapter #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8149612.
…ed UpdateProperty method (not exposed anymore; placed in the Update.cs file)
ZiolkowskiJakub
added
the
status:do-not-merge
ZiolkowskiJakub
requested review from
alelom,
FraserGreenroyd,
IsakNaslundBh and
michaldengusiak
alelom
added
the
status:WIP
|
Hi @alelom, I removed UpdateProperty from the code as you requested. Project can be build now with no errors. Can you please have a look? Thanks! |
ZiolkowskiJakub
added
type:compliance
michaldengusiak
requested changes
Nov 1, 2019
|
Any Error message? When exactly it gives you the error? Printscreen would be appreciated. |
FraserGreenroyd
requested changes
Nov 1, 2019
There was a problem hiding this comment.
Hi @ZiolkowskiJakub - I tried using this PR to just pull a building in an attempt to work out what @michaldengusiak issue is and it appears I'm now unable to pull. See screenshot below. Please advise if I need to change the way I'm doing the pull or whether this ought to work? 😄
|
Simple test files: |
FraserGreenroyd
approved these changes
Nov 1, 2019
ZiolkowskiJakub
removed
the
status:do-not-merge
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM_Adapter#151
Issues addressed by this PR
Closes #425
Updating adapter to align with changes in the parent BHoMAdapter
Test files
All previous scripts should still be working as before.
Additional comments