Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #463

Merged

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Nov 19, 2019

Issues addressed by this PR

Closes #439
Closes #458
Closes #462

Test files

No test files needed - just make sure the code compiles.

Changelog

  • Unused public methods were deprecated:
    • BH.UI.Revit.Engine.Query.MaterialType
    • BH.UI.Revit.Engine.Query.NextLevel
    • BH.UI.Revit.Engine.Query.SelectionBuiltInCategories
    • BH.Engine.Adapters.Revit.Create.Panel
  • Unused private and internal methods were deleted:
    • BH.UI.Revit.Engine.Convert.ToRevitElementType
    • BH.UI.Revit.Engine.Convert.ToBHoMObject2DProperties
    • BH.UI.Revit.Engine.Modify.ContainsDisciplineProperties
    • BH.UI.Revit.Engine.Modify.GetMaterialProperties
    • BH.UI.Revit.Engine.Query.VerticalBounds
  • Irrelevant, commented out code has been deleted
  • BH.UI.Revit.Engine.Modify.AppendBuiltInCategories method name has been changed to Append
  • return type of method BH.UI.Revit.Engine.Convert.ToBHoMLevel has been changed from BHoMObject to BH.oM.Geometry.SettingOut.Level
  • return type of method BH.UI.Revit.Engine.Convert.ToBHoMGrid has been changed from BHoMObject to BH.oM.Geometry.SettingOut.Grid
  • Unused methods were removed
    • BH.UI.Revit.Engine.Query.SpatialElementIds
    • BH.UI.Revit.Engine.Query.RevitType
    • BH.UI.Revit.Engine.Query.BuiltInCategory - first two methods
    • BH.UI.Revit.Engine.Convert.ToRevitElementType

Additional comments

@FraserGreenroyd could you please look into the methods below and decide whether they could also be removed/deprecated in this batch?

  • BH.UI.Revit.Engine.Query.SpatialElementIds
  • BH.UI.Revit.Engine.Query.RevitType
  • BH.UI.Revit.Engine.Query.BuiltInCategory - first two methods
  • BH.UI.Revit.Engine.Convert.ToRevitElementType

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments going through the code. Am happy with most things - just a couple of minor questions for consideration.

I will review the items mentioned in the PR later this afternoon and approve/request changes as appropriate at that point 😄

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@MajaLindroth MajaLindroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@FraserGreenroyd FraserGreenroyd merged commit 804429e into master Nov 19, 2019
@FraserGreenroyd FraserGreenroyd deleted the Revit_Toolkit-Issues439,458,462-RefactorAndCleanup branch November 19, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants