-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup #463
Code cleanup #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments going through the code. Am happy with most things - just a couple of minor questions for consideration.
I will review the items mentioned in the PR later this afternoon and approve/request changes as appropriate at that point 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Issues addressed by this PR
Closes #439
Closes #458
Closes #462
Test files
No test files needed - just make sure the code compiles.
Changelog
BH.UI.Revit.Engine.Query.MaterialType
BH.UI.Revit.Engine.Query.NextLevel
BH.UI.Revit.Engine.Query.SelectionBuiltInCategories
BH.Engine.Adapters.Revit.Create.Panel
BH.UI.Revit.Engine.Convert.ToRevitElementType
BH.UI.Revit.Engine.Convert.ToBHoMObject2DProperties
BH.UI.Revit.Engine.Modify.ContainsDisciplineProperties
BH.UI.Revit.Engine.Modify.GetMaterialProperties
BH.UI.Revit.Engine.Query.VerticalBounds
BH.UI.Revit.Engine.Modify.AppendBuiltInCategories
method name has been changed toAppend
BH.UI.Revit.Engine.Convert.ToBHoMLevel
has been changed fromBHoMObject
toBH.oM.Geometry.SettingOut.Level
BH.UI.Revit.Engine.Convert.ToBHoMGrid
has been changed fromBHoMObject
toBH.oM.Geometry.SettingOut.Grid
BH.UI.Revit.Engine.Query.SpatialElementIds
BH.UI.Revit.Engine.Query.RevitType
BH.UI.Revit.Engine.Query.BuiltInCategory
- first two methodsBH.UI.Revit.Engine.Convert.ToRevitElementType
Additional comments
@FraserGreenroyd could you please look into the methods below and decide whether they could also be removed/deprecated in this batch?
BH.UI.Revit.Engine.Query.SpatialElementIds
BH.UI.Revit.Engine.Query.RevitType
BH.UI.Revit.Engine.Query.BuiltInCategory
- first two methodsBH.UI.Revit.Engine.Convert.ToRevitElementType