Batch cleanup and fix for #440

[pawelbaran]

Issues addressed by this PR

Closes #440

Test files

Not needed.

Changelog

• all internal methods in BH.UI.Revit.Engine that are possibly useful outside Revit_Toolkit were made public

Additional comments

I made another iteration of the batch cleanup - looking forward to getting a few of these in the near future.

[rwemay]

Nice bit of initial tidy up. Approving on the basis of:

• I've scanned through the code and noted that changes are limited to making internal methods public, or formatting of the green header descriptive text;
• I rebuilt and did a quick test on a script that pulls grids - all works ok;
• Good to get uniformity on the public methods for convert/modify/query;

Note that the convert methods don't seem to be in the right namespace (and hence don't show up in the UI). I think should be BH.Engine.Adapters.Revit.Query. With making all these methods public we are naturally exposing a lot into the UI but a) the converts aren't visible anyway at the moment b) I don't think they're widely used in UI's and c) we can always suppress these in some UI's as and where necessary/appropriate.

[pawelbaran]

Note that the convert methods don't seem to be in the right namespace (and hence don't show up in the UI). I think should be BH.Engine.Adapters.Revit.Query. With making all these methods public we are naturally exposing a lot into the UI but a) the converts aren't visible anyway at the moment b) I don't think they're widely used in UI's and c) we can always suppress these in some UI's as and where necessary/appropriate.

All convert/modify/query methods that reference Revit API are stored in BH.UI.Revit.Engine on purpose: Revit API cannot be used outside the Revit context, so there is no benefit of exposing them in the UI (they will all spit errors). However, changing the access level from internal to public makes them available for other projects, which might be useful in some cases.

[FraserGreenroyd]

LGTM... All 288 files of it... 😄