Aligning with changes in BHoMAdapter Refactoring Level 04 #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelbaran
requested review from
alelom,
rwemay,
al-fisher,
FraserGreenroyd,
IsakNaslundBh,
MajaLindroth and
kThorsager
|
Can you use the same PR title as the other PRs @pawelbaran for the change log? Cheers 😄 |
pawelbaran
changed the title
This comment has been minimized.
This comment has been minimized.
pawelbaran
added
the
status:WIP
|
UPDATE: Ready to test, could all of you please run your project scripts if you have any? Thanks! |
pawelbaran
removed
the
status:WIP
IsakNaslundBh
added
the
status:do-not-merge
kThorsager
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
I have tried this on a project and the macro push, and It seams to work but will flag a thing just in case.
Grasshopper crashed quite brutally the first time I tried this and added the Revit Adapter to the script, I have however not been able to replicate this and hope that it was due to building BHoM poorly.
FraserGreenroyd
approved these changes
Jan 23, 2020
MajaLindroth
approved these changes
Jan 23, 2020
FraserGreenroyd
changed the title
FraserGreenroyd
added
the
type:external-api-changes
IsakNaslundBh
approved these changes
Jan 24, 2020
FraserGreenroyd
removed
the
status:do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM_Engine#1371
BHoM/BHoM_Adapter#164
BHoM/BHoM_UI#167
If you use Grasshopper: Aligning with changes in BHoMAdapter Refactoring Level 04 Grasshopper_UI#440
If you use Excel: https://github.com/BHoM/Excel_Toolkit/pull/172
If you use Dynamo: Aligning with changes in BHoMAdapter Refactoring Level 04 Dynamo_UI#188
If you want the Adapter components to be automatically upgraded to their new version in your test scripts: Adding support for method upgrade Versioning_Toolkit#8
Issues addressed by this PR
Closes #486
Test files
Macro push test on SharePoint.
Macro pull tests on SharePoint.
Changelog
Additional comments
It is a crucial PR. Please review carefully as it may crash the whole adapter 🙈