Refactor of the RevitIdentifiers fragment to leverage IAdapterId/PersistentId #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alelom
requested review from
al-fisher,
FraserGreenroyd,
pawelbaran and
rwemay
as code owners
|
@pawelbaran we can finish this next sprint. Maybe if you can have a look tomorrow when I'm away to have a first idea. I still need to do the Versioning. |
|
@BHoMBot check code compliance |
|
@FraserGreenroyd to confirm, |
|
I am closing this PR in agreement with @alelom - the thread had been stale for quite some time already and the branch is obsolete. To be resolved on a new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM#1119
Issues addressed by this PR
Closes #884
Test files
Changelog
Additional comments