Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robot_Toolkit: Change Update method for node constraints #249

Closed
IsakNaslundBh opened this issue Aug 19, 2019 · 0 comments · Fixed by #252 or #310
Closed

Robot_Toolkit: Change Update method for node constraints #249

IsakNaslundBh opened this issue Aug 19, 2019 · 0 comments · Fixed by #252 or #310
Assignees
@IsakNaslundBh
Labels
severity:critical No workaround exists. Essential to continue type:feature New capability or enhancement
Milestone
BHoM 2.4 β MVP

Comments

@IsakNaslundBh
Copy link
Contributor

Description:

The update method for node constraints is currently calling the create method. This is working, but is very slow. The labels just need to get updated instead, which should improve the performance.
@IsakNaslundBh IsakNaslundBh added severity:critical No workaround exists. Essential to continue type:feature New capability or enhancement labels Aug 19, 2019
@IsakNaslundBh IsakNaslundBh self-assigned this Aug 19, 2019
@IsakNaslundBh IsakNaslundBh mentioned this issue Aug 19, 2019
Closed
IsakNaslundBh added a commit that referenced this issue Aug 19, 2019
@IsakNaslundBh
Fixes #249
850c709 
Updating `Update` method for Node constraints. Done to speed up the execution of the method
@IsakNaslundBh IsakNaslundBh mentioned this issue Aug 19, 2019
Merged
@IsakNaslundBh IsakNaslundBh added this to the BHoM 2.4 β MVP milestone Aug 20, 2019
rwemay pushed a commit that referenced this issue Aug 27, 2019
@IsakNaslundBh @rwemay
Fixes #249
b6f2c57 
Updating `Update` method for Node constraints. Done to speed up the execution of the method
@rwemay rwemay mentioned this issue Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IsakNaslundBh IsakNaslundBh

Labels
severity:critical No workaround exists. Essential to continue type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 2.4 β MVP
1 participant
@IsakNaslundBh