Aligning with changes in BHoMAdapter Refactoring Level 04 #65
Conversation
FraserGreenroyd
added
status:do-not-merge
|
This PR replaces #63 for the branch naming issue. You should see that the files changed are the same (i.e. this does not include the assembly file version change previously handled under this branch name) 😄 |
|
Please add some test files |
…/BuroHappoldEngineering/SAP2000_Toolkit into BHoM_Adapter-refactoringLvl04-01
…thub.com/BuroHappoldEngineering/SAP2000_Toolkit into BHoM_Adapter-refactoringLvl04-01" This reverts commit 6a7e54f, reversing changes made to d35d05f.
…tps://github.com/BuroHappoldEngineering/SAP2000_Toolkit into BHoM_Adapter-refactoringLvl04-01"" This reverts commit 9b4e3db.
|
@FraserGreenroyd your move really confused me, sorry for all the reverts and double reverts! hopefully. all this is OK now. |
Sorry! Confusion wasn't meant, honest! Hopefully it's all sorted now? 😄 |
There was a problem hiding this comment.
Approved on the basis of code only, and after the new changes I put in.
This needs testing. As discussed, no testing can be done from my side on this.
Please test this thoroughly and leave a request for changes in case you believe these changes are responsible for breaking any script you have.
|
I will have to approve this on the basis of code changes only. We don't have availability of SAP2000 here in London, so I tried to install a trial version to test it. While the code compiles fine, once we get to the first COM call I get the following: so unfortunately I cannot test the attached file. |
There was a problem hiding this comment.
Again, as explained here #65 (comment)
approved on the basis of code only.
FraserGreenroyd
removed
the
status:do-not-merge
NOTE: Depends on
BHoM/BHoM_Engine#1371
BHoM/BHoM_Adapter#164
BHoM/BHoM_UI#167
If you use Grasshopper: Aligning with changes in BHoMAdapter Refactoring Level 04 Grasshopper_UI#440
If you use Excel: https://github.com/BHoM/Excel_Toolkit/pull/172
If you use Dynamo: Aligning with changes in BHoMAdapter Refactoring Level 04 Dynamo_UI#188
If your Toolkit needs Socket_Toolkit: Aligning with changes in BHoMAdapter Refactoring Level 04 Socket_Toolkit#57
If your Toolkit needs Mongo_Toolkit: Aligning with changes in BHoMAdapter Refactoring Level 04 Mongo_Toolkit#82
If you want the Adapter components to be automatically upgraded to their new version in your test scripts: Adding support for method upgrade Versioning_Toolkit#8
Issues addressed by this PR
Closes #60
Test files
https://burohappold.sharepoint.com/:u:/s/BHoM/EY_K6Z9GTGZHu946_4qR-58BnpHuKz2nvcu1Y7SJX6dw_A?e=3lREM3