Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligning with changes in BHoMAdapter Refactoring Level 04 #114

Merged
merged 4 commits into from
Jan 24, 2020
Merged

Aligning with changes in BHoMAdapter Refactoring Level 04 #114

merged 4 commits into from
Jan 24, 2020

Conversation

FraserGreenroyd
Copy link

@FraserGreenroyd FraserGreenroyd added status:do-not-merge For instance, test PR, requires further discussion, or dependant PRs not ready for merge type:external-api-changes Imposed changes, including from dependency across other BHoM repos labels Jan 16, 2020
@FraserGreenroyd FraserGreenroyd self-assigned this Jan 16, 2020
@IsakNaslundBh
Copy link
Contributor

Sorry, maybe a little sneaky addition, but should have been there if available before, adding the NewModel execute before running each set. Something quite relaxing watching Robot wipe models and push new elements:
Pushing bars Robot Testsets

@epignatelli epignatelli self-requested a review January 24, 2020 09:52
epignatelli
epignatelli approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes for the refactoring, LGTM.
Big part of the diff seems to actually be solving a different problem?

@FraserGreenroyd
Copy link
Author

Big part of the diff seems to actually be solving a different problem?

See @IsakNaslundBh being sneaky 😉

@IsakNaslundBh
Copy link
Contributor

Big part of the diff seems to actually be solving a different problem?

See @IsakNaslundBh being sneaky 😉

Yeah, sorry about that, but was a small change that was enabled by the refactoring and more or less everything being blocked, I added it in..

@epignatelli
Copy link
Member

Big part of the diff seems to actually be solving a different problem?

See @IsakNaslundBh being sneaky 😉

Yeah, sorry about that, but was a small change that was enabled by the refactoring and more or less everything being blocked, I added it in..

gif

@FraserGreenroyd FraserGreenroyd removed the status:do-not-merge For instance, test PR, requires further discussion, or dependant PRs not ready for merge label Jan 24, 2020
@FraserGreenroyd FraserGreenroyd merged commit 51c4cc8 into master Jan 24, 2020
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Adapter-refactoringLvl04-01 branch January 24, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epignatelli epignatelli epignatelli approved these changes

@alelom alelom Awaiting requested review from alelom

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

@al-fisher al-fisher Awaiting requested review from al-fisher

@awakeman awakeman Awaiting requested review from awakeman

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interoperability_Test: Update to adapter lvl04 refactoring
4 participants
@FraserGreenroyd @IsakNaslundBh @epignatelli @alelom