Fix code compliance on oM #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecler
added
type:bug
adecler
requested review from
IsakNaslundBh,
al-fisher,
michaelhoehn and
pawelbaran
Contributor
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
IsakNaslundBh
approved these changes
Mar 20, 2025
Contributor
IsakNaslundBh
left a comment
IsakNaslundBh
left a comment
There was a problem hiding this comment.
Happy with the changes in here.
Tested with provided script, and also checked Against the BHoM_Engine. This helps resolve some of the issues found there as well.
Does what issue says it will do that has signoff from more people as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Fixes #502
Test files
ChecksAnalytics.zip
If you test this on the develop branch, you should get the same output as the report provided in the issue.
If you test it on this PR, you should get zero errors and Warnings should contain the messages from the 3 checks that we downgrades (.i.e. for
HasConstructor,IsValidIImmutableObject, andHasValidConstructor)Additional comments
Additional issue raised here for improving the 3 checks that are temporarily downgraded to warnings.