Tweaks to compliance checks to handle edge cases #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on IsValidCreateMethod
Instead of explicitly checking some specific folder and specific indices simply loop backwards from the filename to the create folder and check if one of the paths is a match. Avoid the copy pasting of regex, and constant index out of bounds exceptions being thrown.
adecler
approved these changes
Mar 20, 2025
Member
adecler
left a comment
adecler
left a comment
There was a problem hiding this comment.
Approving based on
- code review
- testing that all code compliance checks are now passing for the BHoM_Engine using
this script
Member
|
@adecler to confirm, the following actions are now queued:
|
adecler
deleted the
CodeComplianceTest_Engine-#505-FixIncompleteComplianceChecks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #505
Closes #506
Closes #507
Test files
Changelog
Additional comments