Correct the path arguments to correctly filter as intended #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsakNaslundBh
added
status:do-not-merge
Member
|
I agree on not merging this until after the beta release |
Merged
IsakNaslundBh
removed
the
status:do-not-merge
pawelbaran
approved these changes
Jun 2, 2025
Member
pawelbaran
left a comment
pawelbaran
left a comment
There was a problem hiding this comment.
Changes make sense, happy to approve 👍
IsakNaslundBh
deleted the
Test_Toolkit-#509-FixIssueWhereComplianceChecksWhereUnintendentlyTurnedOff
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #509
Fixes issue with stacked path arguments introduced in
#438 (adding _Tests causing those methods not generally being run)
#456 (Making it so that only create methods are checked for method name contains filename)
Test files
Changelog
Additional comments
Suggesting we do not merge this until after the coming beta release, as it might mean significantly more compliance failures. For the checks actually run after putting this back on. Just looking at the BHoM_Engine this will give an additional 245 files failing, mostly due to missing Description attributes.