Provide an upgrade strategy for the case where a class was modified internally #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecler
requested review from
alelom,
rwemay,
al-fisher,
FraserGreenroyd,
IsakNaslundBh and
epignatelli
|
It is worth noting that this PR still contains code that is purely there for test purposes. This code will be removed in a future PR. The later will also include the actual converters for classes already in need of an upgrade. |
FraserGreenroyd
approved these changes
Nov 8, 2019
adecler
deleted the
Versioning_Toolkit-#5-UpgradeForClassInternalChanges
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM_Engine#1301
Issues addressed by this PR
Closes #5
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Test%20Scripts/Versioning_Toolkit/Issue5_deserialise_Test.gh?csf=1&e=Ke9V5v
Additional comments
This is a follow up to PR #2. See #2 (comment) for more details