Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to align to FragmentSet #360

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Changes to align to FragmentSet #360

merged 1 commit into from
Oct 18, 2019

Conversation

alelom
Copy link
Member

@alelom alelom commented Oct 11, 2019 •
edited
Loading

NOTE: Depends on

  1. Fragments in BHoMObject now stored in a FragmentSet instead of in a List BHoM#574 (main BHoM.oM change)
  2. Changes to align to FragmentSet BHoM_Engine#1248 (aligns BHoM_Engine to 1.)

Issues addressed by this PR

Closes #361

Important note

To be merged with BHoM/BHoM_Engine#1248

@alelom alelom marked this pull request as ready for review October 14, 2019 08:52
@alelom alelom added the type:compliance Non-conforming to code guidelines label Oct 14, 2019
@alelom alelom added this to the BHoM 3.0 β MVP milestone Oct 14, 2019
FraserGreenroyd
FraserGreenroyd approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FraserGreenroyd FraserGreenroyd added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Oct 14, 2019
@FraserGreenroyd
Copy link
Contributor

Added do not merge status until dependent PRs are merged.

@alelom alelom mentioned this pull request Oct 16, 2019
Merged
@al-fisher al-fisher removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Oct 18, 2019
@al-fisher al-fisher merged commit 0197c22 into master Oct 18, 2019
@al-fisher al-fisher deleted the BHoM_oM-#573-FragmentsToBeKeyedCollection branch October 18, 2019 17:00
This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees

@alelom alelom

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging this pull request may close these issues.

Align to FragmentSet change
3 participants
@alelom @FraserGreenroyd @al-fisher