Align to changes in BHoM Adapter #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraserGreenroyd
requested review from
alelom,
tg359,
michaldengusiak and
vbeardow
alelom
requested changes
Oct 31, 2019
michaldengusiak
previously requested changes
Nov 1, 2019
FraserGreenroyd
dismissed
michaldengusiak’s stale review
Errors isolated to be within the Revit toolkit
michaldengusiak
approved these changes
Nov 1, 2019
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM_Adapter#151
BHoM/BHoM_UI#149
If testing on Grasshopper, you need Grasshopper_Toolkit branch
If testing on Dynamo, you need Dynamo_Toolkit branch
If testing on Excel_Toolkit, you need Excel_Toolkit branch
If your Toolkit uses Socket_Toolkit: Socket_Toolkit branch
If your Toolkit uses Mongo_Toolkit: Mongo_Toolkit branch
Issues addressed by this PR
Closes #369
Updating adapter to align with changes in the parent BHoMAdapter
Test files
All previous scripts should still be working as before.