Offset openings #375
Merged
Offset openings #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraserGreenroyd
requested changes
Dec 2, 2019
There was a problem hiding this comment.
Sorry @MajaLindroth , slight change requested to the error message!
XML_Engine/Create/XMLSettings.cs
Outdated
| { | ||
| if (offsetDistance >= 0) | ||
| { | ||
| BH.Engine.Reflection.Compute.RecordWarning("Please set offset distance to be a negative number"); |
There was a problem hiding this comment.
Why should the offset distance be a negative number?
I agree it should be, but the user might not - I would recommend a better error message such as:
Offset distance should be negative to offset the openings inwards, away from the edges of the host panel and ensuring opening area is less than the host panel area. A positive offset will result in openings being larger than the host panel
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #243
Openings will be offset if they are bigger than or equal to the size of the host panel. Added a setting to XML Settings to change the distance.
Test files
Test file
Changelog