Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildingStorey ID update for IndividualSpaceExport #380

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

MajaLindroth
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #231

BuildingsStory id will now show the individual story when doing an IndividualSpaceExport instead of a default "StoreyID".

Test files

Standard tests

Changelog

Additional comments

@MajaLindroth MajaLindroth added the type:bug Error or unexpected behaviour label Dec 11, 2019
@MajaLindroth MajaLindroth self-assigned this Dec 11, 2019
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FraserGreenroyd FraserGreenroyd merged commit cdc71e1 into master Dec 11, 2019
@FraserGreenroyd FraserGreenroyd deleted the XML_Toolkit-#231-IndividualSpaceExport-Storey branch December 11, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML_Toolkit: Fix Storey for IndividualSpaceExport
2 participants