Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade XML Toolkit to NetStandard 2.0 #583

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Upgrade XML Toolkit to NetStandard 2.0 #583

merged 1 commit into from
Aug 23, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #581

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Aug 23, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Aug 23, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@jamesramsden-bh
Copy link
Contributor

@BHoM check installer

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check installer

jamesramsden-bh
jamesramsden-bh previously approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installer bot check is happy, so happy to approve.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Aug 23, 2023 •
edited
Loading

@BHoMBot check installer
@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

jamesramsden-bh
jamesramsden-bh approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resubmitting approval following rebase

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check copyright-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

There are 4 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check branch-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check copyright-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

The check branch-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, versioning, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit d4d3407 into develop Aug 23, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the XML_Toolkit-#581-NetStandard branch August 23, 2023 16:08
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
Merged
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesramsden-bh jamesramsden-bh jamesramsden-bh approved these changes

@CKBoulter CKBoulter Awaiting requested review from CKBoulter

@Tom-Kingstone Tom-Kingstone Awaiting requested review from Tom-Kingstone

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to .NetStandard 2.0
2 participants
@FraserGreenroyd @jamesramsden-bh