Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to react v19 #6729

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Update to react v19 #6729

wants to merge 2 commits into from

Conversation

elkebab
Copy link
Contributor

@elkebab elkebab commented Dec 11, 2024

Noen pakker mangler fortsatt eksplisitt støtte for React v19, så foreslår å vente litt før vi bumper her.
Det ser ut til å virke fint likevel da, men kan føre til at npm i oppfører seg rart / får feil når man installerer React v19 mens andre pakker avhenger av React v18.

Copy link

socket-security bot commented Dec 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/react-dom@19.0.2 None 0 0 B
npm/@types/react@19.0.1 None +1 2.04 MB types
npm/react-dom@19.0.0 Transitive: environment +1 84.2 kB
npm/react@19.0.0 None 0 0 B
npm/yup@1.6.0 None +4 493 kB monastic.panic

🚮 Removed packages: npm/@types/react-dom@18.3.1, npm/@types/react@18.3.13, npm/react-dom@18.3.1, npm/react@18.3.1

View full report↗︎

@elkebab

This comment was marked as resolved.

@elkebab
Copy link
Contributor Author

elkebab commented Jan 9, 2025

react-hemlet-async støtter ikke react v19 atm. Noe av funksjonaliteten der er nå også i React da, men tror ikke det dekker alt vi bruker det til, feks nesting av title, ved at title postfikses med - Nasjonalt vitenarkiv hos oss (som riktignok enkelt kan jobbes rundt). Dette tror jeg derimot er et større problem:

Only render a single <title> at a time. If more than one component renders a <title> tag at the same time, React will place all of those titles in the document head. When this happens, the behavior of browsers and search engines is undefined.

https://react.dev/blog/2024/12/05/react-19#support-for-metadata-tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant