Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NP-46405 Use icon instead of Badge in new tasks filter button #6784

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

elkebab
Copy link
Contributor

@elkebab elkebab commented Dec 20, 2024

Description

Link to Jira issue: https://sikt.atlassian.net/browse/NP-46405

Bruk bare ikon i stedet for ikon wrappet i Badge for filterknapp.

Før:
bilde

Etter:
bilde

Checklist

Ensure that the changes are aligned with the expectations of PO/designer before marking the PR as ready for review.

Also ensure that the following criterias are met:

  • The changes are working as expected
  • The changes are tested OK for different screen sizes
  • The changes are tested OK for a11y
  • Interactive elements have data-testids
  • I have done a QA of my own changes

Note: some of these criterias may not always be relevant, and can simply be marked as completed.

@elkebab elkebab merged commit 2b18ee4 into develop Jan 2, 2025
3 checks passed
@elkebab elkebab deleted the NP-46405-new-tasks-filter-button-icon branch January 2, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants