Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

np-47138: update to java 21 #408

Merged
merged 3 commits into from
Oct 1, 2024
Merged

np-47138: update to java 21 #408

merged 3 commits into from
Oct 1, 2024

Conversation

torarnet
Copy link
Contributor

No description provided.

@torarnet
Copy link
Contributor Author

Still issues with PMD not working, but that should maybe be fixed in separate PR

@torarnet torarnet requested a review from ketilaa September 24, 2024 07:49
ketilaa
ketilaa previously approved these changes Sep 24, 2024
* Add java 21 update fixes

* Use non-star import
Comment on lines 19 to 20
java.sourceCompatibility = JavaVersion.VERSION_21
java.targetCompatibility = JavaVersion.VERSION_21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java {
    java.sourceCompatibility = JavaVersion.VERSION_21
    java.targetCompatibility = JavaVersion.VERSION_21
}

Updated gradle wrapper version in build.gradle to comply with earlier PR bumping commons #407 which upgraded to that version in gradle wrapper properties
@torarnet torarnet requested a review from brinxmat October 1, 2024 08:49
@torarnet torarnet merged commit 153b002 into main Oct 1, 2024
8 checks passed
@torarnet torarnet deleted the np-47138-upgrade-to-java-21 branch October 1, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants