np-47689: Use field verified to know if we should keep id or not on p… #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject contributor we only want id on project contributors that are verified in cristin to make it easier for frontend
torarnet
requested review from
torbjokv,
brinxmat,
StigNorland and
LarsV123
brinxmat
previously approved these changes
Sep 27, 2024
| private URI convertId(String cristinPersonId) { | ||
| return getNvaApiId(cristinPersonId, PERSON_PATH_NVA); | ||
| private URI convertId(Boolean identified, String cristinPersonId) { | ||
| return identifiedFieldNotPresent(identified) || identified |
There was a problem hiding this comment.
So, if we don't have the data, or the person is identifier…we keep the URI?
There was a problem hiding this comment.
Exactly. We dont want to remove the id if the field identified cristin person is missing. This makes it backwards compatible and if we want to enforce the field later it is a simple change in proxy
StigNorland
previously approved these changes
Sep 30, 2024
torbjokv
previously approved these changes
Sep 30, 2024
LarsV123
reviewed
Sep 30, 2024
cristin-commons/src/main/java/no/unit/nva/cristin/model/CristinPerson.java
Show resolved
Hide resolved
.../src/main/java/no/unit/nva/cristin/projects/model/cristin/adapter/CristinPersonToPerson.java
Outdated
Show resolved
Hide resolved
torarnet
dismissed stale reviews from torbjokv, StigNorland, and brinxmat
via
20a2d08
brinxmat
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roject contributor
we only want id on project contributors that are verified in cristin to make it easier for frontend