Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

Allow only identifiable Organizations #342

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Allow only identifiable Organizations #342

wants to merge 4 commits into from

Conversation

brinxmat
Copy link
Contributor

  • Forces construction of identifiable organizations (ones with URIs)
  • Removes underspecified organizations

@brinxmat brinxmat requested a review from ketilaa January 19, 2023 23:19
ketilaa
ketilaa reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@ketilaa ketilaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What code is it the Brage import uses to add affiliations for contributors? Or do we just let them provide faulty data and fixes it on the way to the database?

nva-datamodel-java/src/test/java/no/unit/nva/MigrationTestingOrganizationTest.java
@@ -0,0 +1,29 @@
package no.unit.nva;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will returning null behave when we are parsing a list of Organizations?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ketilaa ketilaa ketilaa approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brinxmat @ketilaa