Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release with labels #16

Merged
merged 2 commits into from
Apr 29, 2020
Merged

New release with labels #16

merged 2 commits into from
Apr 29, 2020

Conversation

svenngjeto
Copy link
Collaborator

No description provided.

@svenngjeto svenngjeto merged commit aa0f33b into master Apr 29, 2020
@@ -9,7 +9,7 @@ Metadata:
Author: Unit
SpdxLicenseId: MIT
LicenseUrl: LICENSE
Labels: ['${CODEBUILD_RESOLVED_SOURCE_VERSION}', '${GIT_REPO}']
Labels: ['git-repo:${GIT_REPO}', 'git-commit:${CODEBUILD_RESOLVED_SOURCE_VERSION}', 'build@${BUILD_TIMESTAMP}']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Found an embedded parameter outside of an "Fn::Sub" at Metadata/AWS::ServerlessRepo::Application/Labels/2

@@ -9,7 +9,7 @@ Metadata:
Author: Unit
SpdxLicenseId: MIT
LicenseUrl: LICENSE
Labels: ['${CODEBUILD_RESOLVED_SOURCE_VERSION}', '${GIT_REPO}']
Labels: ['git-repo:${GIT_REPO}', 'git-commit:${CODEBUILD_RESOLVED_SOURCE_VERSION}', 'build@${BUILD_TIMESTAMP}']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Found an embedded parameter outside of an "Fn::Sub" at Metadata/AWS::ServerlessRepo::Application/Labels/1

@@ -9,7 +9,7 @@ Metadata:
Author: Unit
SpdxLicenseId: MIT
LicenseUrl: LICENSE
Labels: ['${CODEBUILD_RESOLVED_SOURCE_VERSION}', '${GIT_REPO}']
Labels: ['git-repo:${GIT_REPO}', 'git-commit:${CODEBUILD_RESOLVED_SOURCE_VERSION}', 'build@${BUILD_TIMESTAMP}']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Found an embedded parameter outside of an "Fn::Sub" at Metadata/AWS::ServerlessRepo::Application/Labels/0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants