Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some globals aren't working #10

Open
ajwood opened this issue Mar 7, 2016 · 3 comments
Open

Some globals aren't working #10

ajwood opened this issue Mar 7, 2016 · 3 comments
Assignees

Comments

@ajwood
Copy link

ajwood commented Mar 7, 2016

Some globals settings aren't working in the latest version of register. It looks like it might be everything that used to go in register.globals.

I get the impression that regsiter.globals isn't read at all; the variables that used to be defined there are still valid (i.e. they don't trigger an error message when they're in register_UI.globals), but setting them doesn't do anything.

For example:
Slice_background_colour = BLACK;

This doesn't produce an error, but also doesn't change the slice background colour.

@rdvincent rdvincent self-assigned this Mar 7, 2016
@rdvincent
Copy link
Member

The develop branch was changed to ignore register.globals a while ago. However, all of the variables should work. I'll investigate.

@ajwood
Copy link
Author

ajwood commented Mar 7, 2016

I'm on the release-1.0.08 branch of minc-toolkit, putting register at commit 317c9f0

@rdvincent
Copy link
Member

Yes, but I'm pretty sure that tag includes these changes. I'll have a fix in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants