-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rdv branch "blending" not working #13
Comments
Yes, the only combination mode that works as intended right now is "Weights", and it only works for the first two volumes. Getting this working in some reasonable way is one of the stumbling blocks I'm trying to overcome with this branch. |
@gdevenyi Check out the latest. All volumes have their own blend slider, and separate controls for "Blended", "Opaque", or "Off". |
Well, that certainly works now, but that completely breaks my standard "how are these different?" method of sliding left-right to see how the image changes. I presume this is still a work in progress? |
You can swap the volume 0 and 1 images quickly using the 'r' and 'e' keys. |
Shift 'R' and 'E' will swap them immediately, without shift they move slowly. |
@gdevenyi To address your earlier question, yes, this is a work in progress - that's why it is still distinct from the "develop" branch, although I expect to ultimately merge this with develop. Let me know if the 'R'/'E' key trick is insufficient. What I might do is re-add a slider under the "merged" panel, with similar behavior to the original blend slider. It might do something like trade off the weights for two different subgroups of images. |
r/e and R/E work okay, I do like the slider because I can control the speed a bit better. Perhaps it would be better if r/e jumped in a bit larger steps. |
@gdevenyi I'll do what I describe above - I'll add a slider under the "merged" panel on the right that works similarly to the original, just extended somehow to the N-volume case. |
Great, I see how the "n-volume" case is definitely tough for blending purposes. Personally, I'm okay with the "quick blend" stuff only making sense for 2-volume. The n-volume display overlap is great for checking alignments alone, even if we can never sort a sensible quick blend. |
@gdevenyi One question, though, is what is the best arrangement of initial colour mappings for the loaded volumes. I also wonder if custom colour maps would be useful. |
I think it's reasonable to just rotate through the standard maps as n increases. As for custom colour maps, I requested those in #6 :) |
Resolved |
Blend slider seems to be no longer properly scaling the intensities between each scan.
Test case:
load same scan twice, move blend slider, intensity changes when it shouldn't since the scan is the same.
The text was updated successfully, but these errors were encountered: