Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdv branch "blending" not working #13

Closed
gdevenyi opened this issue May 16, 2016 · 12 comments
Closed

rdv branch "blending" not working #13

gdevenyi opened this issue May 16, 2016 · 12 comments
Assignees

Comments

@gdevenyi
Copy link

Blend slider seems to be no longer properly scaling the intensities between each scan.

Test case:
load same scan twice, move blend slider, intensity changes when it shouldn't since the scan is the same.

@rdvincent
Copy link
Member

Yes, the only combination mode that works as intended right now is "Weights", and it only works for the first two volumes. Getting this working in some reasonable way is one of the stumbling blocks I'm trying to overcome with this branch.

@rdvincent
Copy link
Member

@gdevenyi Check out the latest. All volumes have their own blend slider, and separate controls for "Blended", "Opaque", or "Off".

@gdevenyi
Copy link
Author

Well, that certainly works now, but that completely breaks my standard "how are these different?" method of sliding left-right to see how the image changes. I presume this is still a work in progress?

@rdvincent
Copy link
Member

You can swap the volume 0 and 1 images quickly using the 'r' and 'e' keys.

@rdvincent
Copy link
Member

Shift 'R' and 'E' will swap them immediately, without shift they move slowly.

@rdvincent rdvincent self-assigned this May 19, 2016
@rdvincent
Copy link
Member

@gdevenyi To address your earlier question, yes, this is a work in progress - that's why it is still distinct from the "develop" branch, although I expect to ultimately merge this with develop.

Let me know if the 'R'/'E' key trick is insufficient. What I might do is re-add a slider under the "merged" panel, with similar behavior to the original blend slider. It might do something like trade off the weights for two different subgroups of images.

@gdevenyi
Copy link
Author

r/e and R/E work okay, I do like the slider because I can control the speed a bit better. Perhaps it would be better if r/e jumped in a bit larger steps.

@rdvincent
Copy link
Member

@gdevenyi I'll do what I describe above - I'll add a slider under the "merged" panel on the right that works similarly to the original, just extended somehow to the N-volume case.

@gdevenyi
Copy link
Author

Great, I see how the "n-volume" case is definitely tough for blending purposes. Personally, I'm okay with the "quick blend" stuff only making sense for 2-volume.

The n-volume display overlap is great for checking alignments alone, even if we can never sort a sensible quick blend.

@rdvincent
Copy link
Member

@gdevenyi One question, though, is what is the best arrangement of initial colour mappings for the loaded volumes. I also wonder if custom colour maps would be useful.

@gdevenyi
Copy link
Author

I think it's reasonable to just rotate through the standard maps as n increases.

As for custom colour maps, I requested those in #6 :)

@gdevenyi
Copy link
Author

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants