-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
740 update to new teaser use conditions and add new building elements #741
740 update to new teaser use conditions and add new building elements #741
Conversation
… machines to be area specific
Mir ist bei den Änderungen folgendes noch aufgefallen:
--> As activating the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Please add the changes according to my review.
@DaJansenGit Please also update the test resources (include the moved files). I tried to update the submodule already (deleting, initialization ...) Current Infrastructure is CI: False |
…se-conditions # Conflicts: # bim2sim/plugins/PluginTEASER/bim2sim_teaser/task/export_teaser.py
…ce by sim_setting and add tests
…ce by sim_setting and add tests
…se-conditions # Conflicts: # bim2sim/elements/mapping/attribute.py # test/unit/elements/mapping/test_attribute.py
…ion test fails due to missing data). Set default for passed_regression_test to False
As @veronikarichter suggested, I moved the reset() functionality into a separate branch and PR.
Before we can merge this, we need to
maintained_illuminance
calculation as default (which I suggest due to much more realistic internal loads through lights)Changes
construction_class_walls= kfw_40
This closes update to new teaser use conditions #740