Consume the title and description of src assets

BKWLD · Oct 28, 2024 · 828a2bb · 828a2bb
1 parent 249361a
commit 828a2bb
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 1 deletion.
diff --git a/packages/contentful/cypress/component/ContentfulVisual.cy.tsx b/packages/contentful/cypress/component/ContentfulVisual.cy.tsx
@@ -113,4 +113,32 @@ describe('contentful visual entry props', () => {
       .should('contain', videoAsset.url)
   })
 
+  it('finds alt on src image', () => {
+    cy.mount(
+      <ContentfulVisual
+        src={{
+          ...visualEntry,
+          alt: null,
+        }}
+      />
+    );
+    cy.get("img").invoke("attr", "alt").should("eq", "Landscape gradient");
+  })
+
+  it("finds alt on src video", () => {
+    cy.mount(
+      <ContentfulVisual
+        src={{
+          ...visualEntry,
+          image: null,
+          portraitImage: null,
+          alt: null,
+        }}
+      />
+    );
+    cy.get("video")
+      .invoke("attr", "aria-label")
+      .should("eq", "Background loop description");
+  });
+
 })
diff --git a/packages/contentful/src/ContentfulVisual.tsx b/packages/contentful/src/ContentfulVisual.tsx
@@ -55,7 +55,14 @@ export default function ContentfulVisual(
           responsiveAspectCalculator :
           getImageAspect(image || src?.image || src?.portraitImage)
       )}
-      alt={ alt || src?.alt || makeAssetAlt(image) || makeAssetAlt(video)}
+      alt={
+        alt
+        || src?.alt
+        || makeAssetAlt(src?.image)
+        || makeAssetAlt(image)
+        || makeAssetAlt(src?.video)
+        || makeAssetAlt(video)
+      }
     />
   )
 }