Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility controls #43

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Add accessibility controls #43

merged 4 commits into from
Aug 14, 2024

Conversation

weotch
Copy link
Member

@weotch weotch commented Aug 14, 2024

Closes #42

  • Implement UI
  • Update the play/pause state (tricky because I'm not controlling this state internally)
  • Update docs

Copy link

codesandbox bot commented Aug 14, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

cypress bot commented Aug 14, 2024



Test summary

15 0 0 0


Run details

Project react-visual
Status Passed
Commit 109c1e3
Started Aug 14, 2024 3:11 PM
Ended Aug 14, 2024 3:11 PM
Duration 00:05 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@weotch
Copy link
Member Author

weotch commented Aug 14, 2024

Looks like this:

image

@weotch weotch merged commit 8f76125 into main Aug 14, 2024
5 checks passed
@weotch weotch deleted the ada-video-controls branch August 14, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pause/play controls by default when video is present for ADA
1 participant