Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-substantive changes per recommendations #21

Closed
wants to merge 2 commits into from
Closed

Non-substantive changes per recommendations #21

wants to merge 2 commits into from

Conversation

dathbe
Copy link

@dathbe dathbe commented Mar 25, 2024

Non-substantive changes as recommended here https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/blob/main/result.md#MMM-Multimonth-by-BKeyport

They also recommend the following:

  • The license in package.json does not match the LICENSE file description
  • Adding ESLint
  • changing primary branch name to main

Note: I don't recommend changing the branch name because it will mess with git pull

new Date() >new Date(Date.now())
Add Updating section
@BKeyport
Copy link
Owner

Declined - unneeded change to MMM-Multimonth.js:

No parameters
When no parameters are provided, the newly-created Date object represents the current date and time as of the time of instantiation. The returned date's timestamp is the same as the number returned by Date.now().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants