build(CMake): support running tests with ctest #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurningEnlightenment
requested changes
Jul 3, 2024
There was a problem hiding this comment.
Building tests should always be optional. Please add an option BUILD_TESTING or BLAKE3_BUILD_TESTING, conditionally call enable_testing(), and conditionally build the test target.
I'll defer to @oconnor663 as to whether we want to integrate the test environment with CMake.
|
Sure thing, both suggestions done. |
|
ping? It would really help as at Gentoo Linux. |
BurningEnlightenment
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
An option(BLAKE3_BUILD_TESTING … would be nice to have for the GUI people. However, I'm fine with this as is. Thanks for the contribution 🙏
@oconnor663 still needs to decide, whether we want this or not.
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Aug 9, 2024
See: BLAKE3-team/BLAKE3#405 Bug: https://bugs.gentoo.org/935370 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
4 tasks
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Aug 9, 2024
See: BLAKE3-team/BLAKE3#405 Bug: https://bugs.gentoo.org/935370 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Aug 9, 2024
See: BLAKE3-team/BLAKE3#405 Bug: https://bugs.gentoo.org/935370 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Aug 9, 2024
See: BLAKE3-team/BLAKE3#405 Bug: https://bugs.gentoo.org/935370 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Aug 9, 2024
See: BLAKE3-team/BLAKE3#405 Bug: https://bugs.gentoo.org/935370 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk> Closes: #38021 Signed-off-by: Michał Górny <mgorny@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to run the test suite via
ctest. Works with both in-source and out-of-source builds. Respects user flags, and builds SIMD into the tests corresponding to whatever was used to build the library. Does not interfere with the ability to run tests the old way.