Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds fields to levels of organisation units #77

Merged
merged 2 commits into from
Dec 31, 2024
Merged

fix: adds fields to levels of organisation units #77

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82d6cab
fix: adds feilds to levels of organisation units
nazarfil Dec 30, 2024
09f728b
move out fields split
nazarfil Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions openhexa/toolbox/dhis2/dhis2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,24 +51,23 @@ def identifiable_objects(self, uid: str) -> dict:
r = self.client.api.get(f"identifiableObjects/{uid}")
return r

def organisation_unit_levels(self) -> List[dict]:
def organisation_unit_levels(self, fields: str = "id,name,level") -> List[dict]:
"""Get names of all organisation unit levels.

Parameters
----------
fields: str, optional
DHIS2 fields to include in the response, where default value is "id,name,level"
Return
------
list of dict
Id, number and name of each org unit level.
"""
r = self.client.api.get("filledOrganisationUnitLevels")
params = {"fields": fields}
r = self.client.api.get("filledOrganisationUnitLevels", params=params)
levels = []
for level in r:
levels.append(
{
"id": level.get("id"),
"level": level.get("level"),
"name": level.get("name"),
}
)
levels.append({k: v for k, v in level.items() if k in fields.split(",")})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Minor] fields.split(",") can be extracted from the loop, it improves a bit the performance

return levels

def organisation_units(self, fields: str = "id,name,level,path,geometry", filter: str = None) -> List[dict]:
Expand Down
Loading