Support for newer rubies

[pjaspers]

This adds support for rubies greater than 2.5 (including the newish ruby 2.7)

In 2.6 they deprecated BigDecimal.new which was used by Dentaku so I had to upgrade, Dentaku as well, they added some functions we already added (but we don't seem to clash).

The other big changes are ruby being more strict about calling functions with keyword arguments.

I've taken some timings along the way (by running the test suite three times):

Baseline (without) any changes: 10.66s

- Finished in 10.55 seconds (files took 1.53 seconds to load) - Finished in 11.77 seconds (files took 1.03 seconds to load) - Finished in 9.67 seconds (files took 1.14 seconds to load)

After bundle update: 10.85s

Finished in 11.05 seconds (files took 1.74 seconds to load) Finished in 10.16 seconds (files took 1.01 seconds to load) Finished in 11.35 seconds (files took 1.14 seconds to load)

Dentaku update: 10.6s

Finished in 10.9 seconds (files took 1.48 seconds to load) Finished in 10.47 seconds (files took 1.03 seconds to load) Finished in 10.43 seconds (files took 1.08 seconds to load)

Ruby 2.7.1: 10.86s

(these are chronologically, so the ruby 2.7.1 has all the other updates in it as well)

So I don't really see any big regressions, but the proof in the pudding will be to run the tests in orbf2 with newer rubies. Based on this, we know that the engine will supports them.

Travis will now run the test suite for all three ruby versions: 2.5, 2.6 and 2.7

[mestachs]

my timings

• master : Finished in 6.74 seconds (files took 0.69376 seconds to load)
• 2.5 & branch : Finished in 6.96 seconds (files took 0.70392 seconds to load)
• 2.6.6 & branch : Finished in 7.82 seconds (files took 0.72265 seconds to load)
• 2.7.1 & branch : Finished in 7.78 seconds (files took 0.73129 seconds to load)

2.7.1 causing a lot of warnings :

.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/mime-types-3.3/lib/mime/types/logger.rb:30: warning: `_1' is reserved for numbered parameter; consider another name
.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/mime-types-3.3/lib/mime/types/logger.rb:30: warning: `_2' is reserved for numbered parameter; consider another name
.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/mime-types-3.3/lib/mime/types/logger.rb:30: warning: `_3' is reserved for numbered parameter; consider another name
.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/json-2.2.0/lib/json/common.rb:156: warning: Using the last argument as keyword parameters is deprecated

did a bundle update and re-run on 2.7.1, most warnings disappeared
Finished in 7.54 seconds (files took 0.72817 seconds to load)

That's still a lot slower for compared to 2.5.
I remember dropping the ** or * usage significantly improved the perf.

[mestachs]

2.7.1 reverting https://github.com/BLSQ/orbf-rules_engine/pull/63/files#diff-2d8c0e5a8f1f0a37f717eae85275cba7R73

Finished in 7.23 seconds (files took 0.70755 seconds to load)

[mestachs]

pkill firefox
pkill code
with the revert
ruby 2.7.1 Finished in 7.07 seconds (files took 0.68045 seconds to load)
ruby 2.5.1 Finished in 6.61 seconds (files took 0.68011 seconds to load)

[pjaspers]

OK, I'll look into the revert. See if I can avoid the **

[mestachs]

now going to bed... but why don't you observe the same timings...

[pjaspers]

I have a much slower computer :) But the results are kind of in line (and the double splat does make a big difference).

My fix for the warning was actually not really the right solution to the problem.

class Hi
  def initialize(hash)
    puts hash
  end

  def self.with(hash)
    new(hash)
  end
end

class HiAgain < Hi
  def initialize(it: me)
    # Because we're overriding the initialize with keywords
    # ruby is throwing the warning
  end
end

hi = Hi.with(a: "b", c: "d")
HiAgain.with(it: "me") # this will throw the waring

Is my reduced case, where I can trigger the warning.