Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #5076 is incomplete #5092

Closed
CharlieFenton opened this issue Feb 8, 2023 · 0 comments · Fixed by #5146
Closed

PR #5076 is incomplete #5092

CharlieFenton opened this issue Feb 8, 2023 · 0 comments · Fixed by #5146

Comments

@CharlieFenton
Copy link
Contributor

Manager: don't clear in-use prefs when disable in-use computing #5076 still clears certain values when it should not.

  • With Suspend when non_BOINC CPU usage is above xxx % checked (set on) in either section (when computer is in use or when computer is not in use) :
    - Uncheck it (turn it off).
    - The value is not preserved when that checkbox is again set (turned on.)

  • In the When computer is in use section, with Suspend when computer is in use unchecked (off) and Suspend when non_BOINC CPU usage is above xxx % checked (set on):
    - Check (turn on) Suspend when computer is in use and click on Save.
    - Reopen the dialog
    - The Suspend when non_BOINC CPU usage is above xxx % is no longer checked, and its previous value is lost.

  • With Suspend if no mouse or keyboard input in last xxx minutes checked (set on), enter a value for it.
    - Uncheck it (turned it off).
    - The value is not preserved when that checkbox is again set (turned on.)

I realize that this last is no directly related to the new not-in-use preferences, but it hound be fixed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants