Manager: don't clear in-use prefs when disable in-use computing #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In-use prefs: - cpu_usage_limit - max_ncpus_pct - ram_max_used_busy_frac - suspend_cpu_usage Don't clear their values when in-use computing is disable, and write them to the override file. That way if the user enables in-use computing again, they'll see the values they had set before.
AenBleidd
approved these changes
Jan 26, 2023
|
Code looks good to me but testing is required. |
Recall: the client has - web prefs: from a project or AM. global_prefs.xml - local prefs: global_prefs_override.xml Prefs from an AM have priority over prefs from projects. If the client is using an AM and has prefs from it, prefs from a project (in a scheduler reply) are silently ignored. Change things so that prefs from a project are accepted (written to global_prefs.xml) if you're using an AM but are using local prefs. So if you're using an AM and want prefs from a project P: - switch to local prefs - update P - switch to web prefs (which will now be from P). This is admittedly awkward.
This was referenced Feb 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-use prefs:
Don't clear their values when in-use computing is disabled, and write them to the override file.
That way if the user enables in-use computing again, they'll see the values they had set before.
Fixes some of Charlie's comments in #5072