boinccmd: show CPU/GPU resources in --get_task #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also only show relevant info. E.g. don't show exit status of a job that hasn't finished.
TheAspens
reviewed
Jan 29, 2018
| @@ -160,26 +160,37 @@ void RESULT::print() { | |||
| foo = (time_t)report_deadline; | |||
| printf(" report deadline: %s", ctime(&foo)); | |||
| printf(" ready to report: %s\n", ready_to_report?"yes":"no"); | |||
| printf(" got server ack: %s\n", got_server_ack?"yes":"no"); | |||
There was a problem hiding this comment.
Was the line
printf(" got server ack: %s\n", got_server_ack?"yes":"no");
intentionally dropped?
|
I've tested this and it looks fine. Once I get an answer to the comment I made above I will be able to merge. |
|
It was intentionally dropped. Once a result is acked by the server,
it's garbage-collected within a few seconds.
…On Mon, Jan 29, 2018 at 1:29 PM, Kevin Reed ***@***.***> wrote:
I've tested this and it looks fine. Once I get an answer to the comment I
made above I will be able to merge.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2327 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA8KgaD85hF0sXZC53_fcdgACXv-MFSKks5tPjgxgaJpZM4RvMKz>
.
|
|
Ok thanks for the clarification. I'm approving and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also only show relevant info.
E.g. don't show exit status of a job that hasn't finished.