Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow page_head() to be called twice #2979

Merged
merged 1 commit into from
Feb 2, 2019
Merged

Conversation

Rytiss
Copy link
Contributor

@Rytiss Rytiss commented Jan 23, 2019

Description of the Change

error_page() calls page_head(), but there are instances of code that call error_page() having already called page_head() before, thus attempting to send headers twice and creating double page header.

Fixes #2960

Release Notes
Prevent page_head() from being called multiple times. Notice to projects: If you have a page_head() function override in your project.inc you need to apply this change there too.

error_page() calls page_head(), but there are instances of code that call error_page() having already called page_head() before, thus attempting to send headers twice and creating double page header.

Fixes #2960
@ChristianBeer
Copy link
Member

This definitely fixes the problem but there should be an entry in the server release notes because existing projects that have this function overridden in their project config need to also change those or still suffer from the problem.

@Rytiss
Copy link
Contributor Author

Rytiss commented Jan 25, 2019

This definitely fixes the problem but there should be an entry in the server release notes because existing projects that have this function overridden in their project config need to also change those or still suffer from the problem.

Updated the release notes field in the original description above. Do I need to do anything else?

@ChristianBeer
Copy link
Member

I added: "Notice to projects: If you have a page_head() function override in your project.inc you need to apply this change there too." to the release note and confirmed that it fixes the issue.

Thanks for your contribution.

@ChristianBeer ChristianBeer merged commit 94b2872 into master Feb 2, 2019
@ChristianBeer ChristianBeer deleted the Rytiss-pagehead branch February 2, 2019 09:39
@AenBleidd AenBleidd added this to the Server Release 1.2.0 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web: wrong use of error_page() function throughout the code
3 participants