Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal: Fixed registration form terms-of-use checkbox #3063

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

drshawnkwang
Copy link
Contributor

Description of the Change
Fixes broken user registration form.

Release Notes
N/A

https://dev.gridrepublic.org/browse/DBOINCP-497

@brevilo
Copy link
Contributor

brevilo commented Mar 18, 2019

Just to make sure, boincuser_termsofuse_form_validate() shouldn't be used here?

@drshawnkwang
Copy link
Contributor Author

drshawnkwang commented Mar 18, 2019

No, that function is for a second form that is separate. I believe that form is for users who had accounts before terms-of-use was implemented. They are forced to see the form when the login. It has the same construct. That was the bug: I changed the check if-statement in the function boincuser_termsofuse_form_validate and not the other (or this, or relevant) boincuser_register_validate, which is being fixed in this PR.

@brevilo
Copy link
Contributor

brevilo commented Mar 18, 2019

Yeah, I understand the solution but just wanted to avoid the apparent code redundancy. But agreed, that could be followed up separately.

@brevilo brevilo merged commit 5cf754a into BOINC:master Mar 18, 2019
@drshawnkwang drshawnkwang deleted the drupal_fix-registrationform branch March 27, 2019 15:28
@AenBleidd AenBleidd added this to the Server Release 1.2.0 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants