Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated VBoxManage command #5542

Merged

Conversation

computezrmle
Copy link
Contributor

The changelog for VirtualBox 7.0.6 (released January 17 2023) states this:
"Audio: The "--audio" option in VBoxManage is now marked as deprecated; please use "--audio-driver" and "--audio-enabled" instead. This will allow more flexibility when changing the driver and/or controlling the audio functionality"

See:
https://www.virtualbox.org/wiki/Changelog-7.0#v6

Since vboxwrapper uses "--audio none" to disable the VM's audio hardware it should be modified to a conditional "--audio-enabled off" for VirtualBox releases newer than 7.0.4.

Replace "--audio none" with conditional "--audio-enabled off"
samples/vboxwrapper/vbox_vboxmanage.cpp Outdated Show resolved Hide resolved
samples/vboxwrapper/vbox_vboxmanage.cpp Outdated Show resolved Hide resolved
Added a space at the end of each command string.
@computezrmle computezrmle requested a review from AenBleidd March 20, 2024 12:16
@AenBleidd AenBleidd merged commit 3b73f7b into BOINC:master Mar 20, 2024
90 of 92 checks passed
@computezrmle computezrmle deleted the computezrmle-replace_deprecated_audio branch March 22, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants