Fix #302 #309
Open
Fix #302 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disabled https://github.com/s-weigand/docformatter because leading to an error ``` pre-commit run --all-files [INFO] Initializing environment for https://github.com/s-weigand/docformatter. An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'checkout', '1ec30b7') return code: 1 stdout: (none) stderr: error: pathspec '1ec30b7' did not match any file(s) known to git Check the log at /home/myuser/.cache/pre-commit/pre-commit.log ```
|
Thank you for tracking and solving this problem! I appreciate your contribution. Your solution is simple and should work with a little tweaking. I am worried the current PR may introduce bugs when two measurement placeholders with different names in the circuit, each with multiple measures, are saved to qasm. What do you think about making the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with the QASM exporter, which previously failed to export circuits containing classical registers (see #302 ).
To ensure the correctness of the fix, I have added additional test cases to cover scenarios involving one or multiple classical registers imported via Qiskit.
Please review the changes and let me know if you have any feedback or concerns.