Draft: Gl 1316 dependencies

[kinow]

In GitLab by @dbeltrankyl on Nov 21, 2024, 09:18

Fixes part of !1316, as mentioned in the last AS meeting.

That is, add the "?" question mark to mark failed jobs as failed or "any other final status," while failing without "?" indicates only failed.

Refactored a horrible function in the plot side.

• Pending pytests
• Requires Gl as1316 dependencies autosubmit-config-parser#53

That branch (pytests already added) divides the "status: failed?":

JOBS:
  JOB:
    DEPENDENCIES:
       A:
          Status: "failed?"

To:

JOBS:
  JOB:
    DEPENDENCIES:
       A:
          Status: "FAILED"
          ANY_FINAL_STATUS_IS_VALID: True

That is what this branch needs to have.

[kinow]

In GitLab by @dbeltrankyl on Nov 21, 2024, 09:22

marked this merge request as draft

[kinow]

In GitLab by @dbeltrankyl on Nov 21, 2024, 11:30

added 13 commits

• 72849a2b...6a6badd9 - 10 commits from branch master
• f85e00e8 - (WIP) Added "?"
• a47935c5 - (WIP) optional always true for running
• d02597b0 - code working ( together with autosubmitconfig parser update ) pytest missing

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Nov 21, 2024, 11:30

added 1 commit

• 7dfe7738 - Update as_conf VERSION

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Nov 25, 2024, 16:26

added 1 commit

• 4b2fa8cb - Added test for job_list

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Nov 25, 2024, 16:27

added 9 commits

• 4b2fa8cb...9ed9bc0f - 4 commits from branch master
• 07205cd - (WIP) Added "?"
• b2c19e4 - (WIP) optional always true for running
• 1cfa0c0 - code working ( together with autosubmitconfig parser update ) pytest missing
• 6f10948 - Update as_conf VERSION
• db14ce7 - Added test for job_list

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Nov 27, 2024, 15:39

added 2 commits

• 878ba24 - (wip)
• f132fc5 - Removed deprecated code and added a condition that replaces it

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Nov 27, 2024, 15:42

added 1 commit

• 43784d6 - Check other parents in check_special_status

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Nov 27, 2024, 15:43

added 1 commit

• 9d3a641 - Check other parents in check_special_status

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Nov 27, 2024, 15:44

• Removed old deprecated code for weak dependencies for a new condition
• Added a TODO due to a test missing in a 240 lines function for the condition I mentioned
  • This part of the code is being tested by the regression tests like check_db tho
• Requires More fixes for AS1316 issue autosubmit-config-parser#55
• Pending pytest for one part of check_special_status

[kinow]

In GitLab by @dbeltrankyl on Nov 27, 2024, 15:44

marked the checklist item Requires BSC-ES/autosubmit-config-parser#53 as completed

[kinow]

In GitLab by @dbeltrankyl on Nov 27, 2024, 15:48

added 1 commit

• 54f7897 - Changed default value for {} instead of None

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Nov 27, 2024, 15:53

added 1 commit

• 125c2fc - Fixed tests due new calls

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Nov 28, 2024, 09:43

Commented on autosubmit/job/job_list.py line 989

This is uncovered. But it is because this part is being tested with a script that tests all docs of the experiment that is being launched manually, hopeful with GitHub I'll be able to integrate the test into the pipeline

The addition is just to withdraw the new key added in the related autosubmit config parser before passing the filters to the filter functions

[kinow]

In GitLab by @kinow on Nov 28, 2024, 09:47

Commented on autosubmit/job/job_list.py line 989

Maybe it'd be good for the reviewer to have access to the script and test it too. Just being over cautious as 4.1.12 is going to d-suite in climatedt. Or maybe some instructions on how to write a quick experiment locally that would reach this part of the code (I do that sometimes to run everything with the IDE debugger and review/understand the code).

[kinow]

In GitLab by @dbeltrankyl on Nov 28, 2024, 09:58

added 1 commit

• 10f8073 - Added pytest

Compare with previous version

[kinow]

In GitLab by @dbeltrankyl on Nov 28, 2024, 14:08

marked the checklist item Pending pytests as completed

[kinow]

In GitLab by @dbeltrankyl on Nov 28, 2024, 14:29

Commented on autosubmit/job/job_list.py line 989

moved to https://earth.bsc.es/gitlab/es/autosubmit/-/merge_requests/524

Tests instructions added

[kinow]

In GitLab by @dbeltrankyl on Nov 28, 2024, 14:31

Pipeline working ( was once again, the clear cache button )