Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust log_path for existing job_list #2070

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Adjust log_path for existing job_list #2070

merged 1 commit into from
Jan 20, 2025

Conversation

dbeltrankyl
Copy link
Contributor

This branches fixes a bug related with recovery + log_path when it continues the run with a job_list of a previous version.

Ready to review

@dbeltrankyl dbeltrankyl requested a review from kinow January 20, 2025 09:51
@dbeltrankyl dbeltrankyl self-assigned this Jan 20, 2025
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably should include it in 4.1.12-release branch too, for our next release soon-ish. Thank you!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.93%. Comparing base (120c335) to head (da4bc21).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2070   +/-   ##
=======================================
  Coverage   48.92%   48.93%           
=======================================
  Files          72       72           
  Lines       17541    17543    +2     
  Branches     3415     3416    +1     
=======================================
+ Hits         8582     8584    +2     
  Misses       8154     8154           
  Partials      805      805           
Flag Coverage Δ
fast-tests 48.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbeltrankyl dbeltrankyl merged commit 81f4079 into master Jan 20, 2025
8 checks passed
@kinow kinow deleted the 4.1.12-log_path branch January 20, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants