fix: adapt to subscan paging limit #2037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilted-andres
force-pushed
the
xw--paging-limit-exceeded
branch
from
4219dbc
to
ab3e20f
Compare
arty-name
reviewed
Mar 20, 2024
| // SubScan returns some AttesterOf values as hex without the "0x" prefix | ||
| // so we first parsed to a Uint8Array via `hexToU8a`, which can handle HexStrings with or without the prefix. | ||
| const didU8a = hexToU8a(didAccount); | ||
|
|
||
| const didUri = Did.fromChain(didU8a as AccountId32); | ||
| logger.debug('Corresponding DID-URI: ' + didUri); |
There was a problem hiding this comment.
Could it then become as simple as return Did.fromChain(didU8a as AccountId32);?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new restriction from the new Subscan-API that I could not find anywhere in their documentation.
There is a page limit of 100. Trying to query
"page": 101will result in an error message.To stay within the limit and don't miss any events, we reduce the block range of the queries when necessary.