Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

WGBH-DCAMM, Deliverable 1, cleaned up PR #59

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Conversation

jenajjedu
Copy link
Contributor

@jenajjedu jenajjedu commented Mar 5, 2021

Description of Change

Added our Deliverable 1 with a corrected pull request. As a team, we were only using one branch to commit changes and this caused a problem with updates that got propagated to our existing PR. I see that the first PR for Deliverable 1 was merged so perhaps I did not need to do this work. I created a new branch for delv_1 with only deliverable 1 changes in this PR. The first deliverable 1 PR and this one are identical with respect to the work done for deliverable 1. I was concerned that the first PR got extraneous files attached to it.

Our project Kanban board is:
https://github.com/BU-Spark/CS506Spring2021Repository/projects/13#column-13226542

Team Name and Contributors

Students Rep Jena Jordahl jenajj@bu.edu,
Elisa Cordeiro Lopes elisacl@bu.edu, Richard Lee rlee99@bu.edu
Murtadha - Ahmad M Al Bahranimurtadha@bu.edu
Carmen - Sabrina Araujosabrinaa@bu.edu

Github accounts
elisa3lopes, rlee99, murtio, carmen-araujo, jenajjedu

Checklist

Before creating your PR, please ensure the following requirements.

General

  • [ √ ] PR does not include irrelevant or hidden files (i.e. __pycache__, .vscode... etc.)
  • [ √ ] Changes are in the correct folder
  • [ √ ] There are no merge conflicts
  • [ √ ] Commit messages are sensible and descriptive

Code

  • [ √ ] Implementation matches proposed design
  • [ √ ] Documentation on how to run the code is created/updated
  • [ √ ] Code is legible

Report

  • [ √ ] Report meets the deliverable criteria
  • [ √ ] Proposal is up to date with latest decisions

@jenajjedu jenajjedu changed the title Correctly merged Deliverable 1 WGBH-DCAMM, Deliverable 1 Mar 9, 2021
@jenajjedu jenajjedu changed the title WGBH-DCAMM, Deliverable 1 WGBH, Deliverable 1 Mar 9, 2021
@jenajjedu jenajjedu changed the title WGBH, Deliverable 1 WGBH-DCAMM, Deliverable 1 Mar 9, 2021
@jenajjedu jenajjedu changed the title WGBH-DCAMM, Deliverable 1 WGBH-DCAMM, Deliverable 1, cleaned up PR Mar 9, 2021
@lingyanj lingyanj merged commit 74e3cca into BU-Spark:master Mar 19, 2021
@jenajjedu jenajjedu deleted the delv_1 branch April 30, 2021 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants