Mention the web build script in examples/README.md #517
Conversation
build.bash
Outdated
| @@ -15,7 +15,7 @@ case $1 in | |||
| RUSTFLAGS=--cfg=web_sys_unstable_apis cargo build --target wasm32-unknown-unknown $BUILD_FLAGS --bin $@ | |||
| mkdir -p target/generated/ | |||
| rm -rf target/generated/* | |||
| cp -r examples/$1/resources target/generated/ || true | |||
| cp -r examples/resources target/generated/ || true | |||
There was a problem hiding this comment.
This is intentional - some examples (notably scene-viewer) do have resources that need to be copied. The || true lets this command fail, only copying the resources if they exist.
There was a problem hiding this comment.
I undid that change, but now there're two commits and i have no idea about squashing and merging them unfortunately.
There was a problem hiding this comment.
Github can squash for you, no worries.
There was a problem hiding this comment.
Oh, cool! I had a look but couldn't find anything.
There was a problem hiding this comment.
Just tried again manually and fucked it up again; feel free to deny/cancel this pull request, i've no idea what i'm doing.
Oh no wait, it should be git push --force at the end! Every time i've tried it before the number of commits just got bigger...
ghost
marked this pull request as draft
Head branch was pushed to by a user without write access
Description
I think the
build.bashscript should be mentioned in the README.Related Issues
The build script tried to move resources from the nonexistent directory
examples/cube/resources/so I corrected that too.