Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Net.copy_trained_layers_from and Net.share_trained_layers_with in pycaffe #1195

Merged
merged 2 commits into from
Oct 10, 2014

Conversation

longjon
Copy link
Contributor

@longjon longjon commented Oct 1, 2014

This allows finetuning from Python, for example.

Misgivings: copy_trained_layers_from and share_trained_layers_with are very long names, while pycaffe mostly has pretty succinct naming. Also, the layers don't really have to be trained at all, so maybe the simple copy_from and share_with would be better. But these are the names in the C++ interface.

I don't know what will happen if you share_trained_layers_with a net, and then delete that net. But it's the same as what will happen if you do the same in C++; does anyone know how that is handled? For the use case I have in mind (the solver), this issue does not arise, because the solver is holding all the nets.

@longjon longjon changed the title Expose Net.copy_trained_layers_from in pycaffe Expose Net.copy_trained_layers_from and Net.share_trained_layers_with in pycaffe Oct 1, 2014
@shelhamer
Copy link
Member

I like the suggested name change to copy_from and share_with. The interfaces need not be in lock-step. While a close family resemblance is good to keep everything making sense there's a lot to be said for convenience.

shelhamer added a commit that referenced this pull request Oct 10, 2014
Expose Net.copy_from and Net.share_with in pycaffe
@shelhamer shelhamer merged commit 7eecdf9 into BVLC:dev Oct 10, 2014
mitmul pushed a commit to mitmul/caffe that referenced this pull request Oct 11, 2014
Expose Net.copy_from and Net.share_with in pycaffe
RazvanRanca pushed a commit to RazvanRanca/caffe that referenced this pull request Nov 4, 2014
Expose Net.copy_from and Net.share_with in pycaffe
@longjon longjon deleted the python-copy-from branch December 30, 2014 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants