Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary support for yosemite #1237

Closed
wants to merge 3 commits into from

Conversation

leonardt
Copy link

@leonardt leonardt commented Oct 7, 2014

Some changes to the makefile were needed to get caffe built on yosemite.

One change pulled from (https://groups.google.com/d/msg/caffe-users/rXjBlzWkA8c/kEKGeiqZhBAJ)

Build completes and all tests pass, but it's probably good to hold off on merging until someone else with a yosemite dev environment bootstrapped can test it.

@orsharir
Copy link

I've used Caffe on Yosemite for the past month with similar changes made locally and it's working fine so far.

@kloudkl
Copy link
Contributor

kloudkl commented Oct 13, 2014

The official build system is in the process of transition to CMake.

@leonardt
Copy link
Author

Sounds good, if the make based build system is being deprecated than this can be closed.

@shelhamer
Copy link
Member

The Makefile is not deprecated yet and is still the official build system.
The CMake build still isn't up to parity with the Makefile, so it's best to
make the Makefile compatible since CMake is still catching up and fixing
its broken cases.

On Wed, Oct 15, 2014 at 12:19 PM, Leonard Truong notifications@github.com
wrote:

Sounds good, if the make based build system is being deprecated than this
can be closed.


Reply to this email directly or view it on GitHub
#1237 (comment).

@dgolden1
Copy link
Contributor

This PR looks similar to mine: #1310. However, @leonardt, you submitted yours first, so you win!

One difference is that you explicitly check for OS X 10.10 with the line:

ifneq ($(findstring 10.10, $(shell sw_vers -productVersion)),)

However, I believe that the framework not found vecLib issue (#1212) is the result of upgrading to XCode 6, not OS X 10.10, since I am getting it with XCode 6 on OS X 10.9 (Mavericks).

Neither of our PRs actually check for XCode 6 vs XCode 5. So if anyone knows how to do that, that would be a good change; alternatively, we can say that XCode 6 is required.

@leonardt
Copy link
Author

@drdan14 good catch, xcodebuild -version should do the trick.

@dgolden1
Copy link
Contributor

Here's an overly-long bash line that will give you the answer (checking the version of XCode command line tools, not XCode itself):

[[ "`pkgutil --pkg-info=com.apple.pkg.CLTools_Executables | grep version | awk '{print $2}'`" > "6" ]] && echo "true" || echo "false"

@leonardt, maybe you know how to turn that into a Makefile conditional

@leonardt
Copy link
Author

This line seems to do the trick for me ifneq ($(findstring Xcode 6, $(shell xcodebuild -version)),)

@shelhamer
Copy link
Member

I've collected fixes from this and other PRs in #1740. Thanks for noting these changes!

@shelhamer shelhamer closed this Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants