-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preliminary support for yosemite #1237
Conversation
I've used Caffe on Yosemite for the past month with similar changes made locally and it's working fine so far. |
The official build system is in the process of transition to CMake. |
Sounds good, if the make based build system is being deprecated than this can be closed. |
The Makefile is not deprecated yet and is still the official build system. On Wed, Oct 15, 2014 at 12:19 PM, Leonard Truong notifications@github.com
|
This PR looks similar to mine: #1310. However, @leonardt, you submitted yours first, so you win! One difference is that you explicitly check for OS X 10.10 with the line:
However, I believe that the Neither of our PRs actually check for XCode 6 vs XCode 5. So if anyone knows how to do that, that would be a good change; alternatively, we can say that XCode 6 is required. |
@drdan14 good catch, |
Here's an overly-long bash line that will give you the answer (checking the version of XCode command line tools, not XCode itself):
@leonardt, maybe you know how to turn that into a Makefile conditional |
This line seems to do the trick for me |
I've collected fixes from this and other PRs in #1740. Thanks for noting these changes! |
Some changes to the makefile were needed to get caffe built on yosemite.
One change pulled from (https://groups.google.com/d/msg/caffe-users/rXjBlzWkA8c/kEKGeiqZhBAJ)
Build completes and all tests pass, but it's probably good to hold off on merging until someone else with a yosemite dev environment bootstrapped can test it.